Posting here for more visibility, but I have opened a PR to add more rules to the base @medic/eslint-config repo. Thoughts/considerations welcome!
master ← jkuester:common-medic-rules
opened 10:06PM - 14 Feb 25 UTC
# Description
For the sake of consistency (and ease of maintenance), it will … be useful to centralize as much of the eslint config for projects in the `medic` org as possible. This will help us to enforce common code standards across all the code being written.
This PR adds rules that are currently common to both [cht-core](https://github.com/medic/cht-core/blob/d1828ff33eafafa1940ce1db39b7d0934a055243/.eslintrc#L26) and [cht-user-managment](https://github.com/medic/cht-user-management/blob/926bc35841482c2ef599ef17c669c4410c202bbe/.eslintrc#L16) (cht-conf is still the "wild west" when it comes to linting, but I intend to change that eventually....).
I know that this eslint-config is also used by many `config-*` repos (which probably do not already have these linting rules set). My thought is that if these rules are good enough for our source code repos, then it probably makes sense to encourage them in the config repos too. (And eslint config is flexible enough that consumers of this repo can have full override control over these rules, so nothing is being forced here.)
# License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.
This PR is just adding in the rules that are already in common between cht-core and cht-user-management. I encourage everyone to “watch” that repo to get notified of future config proposals!
3 Likes
2 Likes
from me. Consistency rules.